Skip to content

KAFKA-8602: Backport bugfix for standby task creation#7148

Merged
mjsax merged 2 commits intoapache:1.0from
cadonna:standby_task_creation_fix_1_0
Aug 6, 2019
Merged

KAFKA-8602: Backport bugfix for standby task creation#7148
mjsax merged 2 commits intoapache:1.0from
cadonna:standby_task_creation_fix_1_0

Conversation

@cadonna
Copy link
Copy Markdown
Member

@cadonna cadonna commented Aug 1, 2019

Backports bugfix in standby task creation from PR #7008.
A separate PR is needed because some tests in the original PR
use topology optimizations and mocks that were introduced afterwards.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Backports bugfix in standby task creation from PR apache#7008.
A separate PR is needed because some tests in the original PR
use topology optimizations and mocks that were introduced afterwards.
@cadonna
Copy link
Copy Markdown
Member Author

cadonna commented Aug 1, 2019

@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Aug 1, 2019

retest this please

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Aug 1, 2019

Retest this please

@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Aug 1, 2019

Java 7/8 seem related failures Execution failed for task ':streams:compileTestJava'

@cadonna
Copy link
Copy Markdown
Member Author

cadonna commented Aug 2, 2019

Retest this, please

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Aug 4, 2019

Java7 timed out.
Java10 had 10 failing tests (seem unrelated):

org.apache.kafka.common.record.FileRecordsTest.testTruncateNotCalledIfSizeIsBiggerThanTargetSize
org.apache.kafka.common.record.FileRecordsTest.testTruncateNotCalledIfSizeIsSameAsTargetSize
org.apache.kafka.common.record.FileRecordsTest.testTruncateIfSizeIsDifferentToTargetSize
org.apache.kafka.common.utils.UtilsTest.testReadFullyOrFailWithPartialFileChannelReads
org.apache.kafka.common.utils.UtilsTest.testReadFullyWithPartialFileChannelReads
org.apache.kafka.common.utils.UtilsTest.testReadFullyIfEofIsReached
org.apache.kafka.connect.runtime.SourceTaskOffsetCommitterTest.testSchedule
org.apache.kafka.connect.runtime.SourceTaskOffsetCommitterTest.testClose
org.apache.kafka.connect.runtime.SourceTaskOffsetCommitterTest.testRemove
kafka.tools.ConsoleConsumerTest.shouldStopWhenOutputCheckErrorFails

Java8 passed.

Retest this please.

@cadonna
Copy link
Copy Markdown
Member Author

cadonna commented Aug 6, 2019

Java 10 errors are due to https://issues.apache.org/jira/browse/KAFKA-7307.
This build will not become green.

Will retstart builds to check Java 7 timeout

Retest this, please

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Aug 6, 2019

Java7 passed this time. We also got a green Java8 above. Merging.

@mjsax mjsax merged commit 3b729ac into apache:1.0 Aug 6, 2019
@cadonna cadonna deleted the standby_task_creation_fix_1_0 branch October 21, 2019 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants