Skip to content

[WIP] KAFKA-8729, pt 4: Add client-side logic to augment error handling and partially fail records specified in error_records#7168

Closed
tuvtran wants to merge 14 commits intoapache:trunkfrom
tuvtran:kip-467-client-logic
Closed

[WIP] KAFKA-8729, pt 4: Add client-side logic to augment error handling and partially fail records specified in error_records#7168
tuvtran wants to merge 14 commits intoapache:trunkfrom
tuvtran:kip-467-client-logic

Conversation

@tuvtran
Copy link
Copy Markdown
Contributor

@tuvtran tuvtran commented Aug 6, 2019

Added Sender#partialFailBatch and ProducerBatch#partiallyDone to only fail and invoke callbacks of records in error_records.

Modified FutureRecordMetadata to re-bind a record's ProduceRequestResult to that of a new batch.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@tuvtran
Copy link
Copy Markdown
Contributor Author

tuvtran commented Aug 6, 2019

Depending on #7150 to be merged

@tuvtran tuvtran force-pushed the kip-467-client-logic branch from 34e70fb to 2a94c0e Compare September 4, 2019 20:39
@tuvtran
Copy link
Copy Markdown
Contributor Author

tuvtran commented Oct 3, 2019

retest this please

@tuvtran tuvtran force-pushed the kip-467-client-logic branch from 8f565d8 to c68e76a Compare October 5, 2019 00:08
@tuvtran
Copy link
Copy Markdown
Contributor Author

tuvtran commented Oct 10, 2019

retest this please

@tuvtran tuvtran changed the title KAFKA-8729, pt 4: Add client-side logic to augment error handling and partially fail records specified in error_records [WIP] KAFKA-8729, pt 4: Add client-side logic to augment error handling and partially fail records specified in error_records Oct 10, 2019
@tuvtran tuvtran force-pushed the kip-467-client-logic branch from 0a24dff to 9aa86c6 Compare October 11, 2019 00:25
@github-actions
Copy link
Copy Markdown

This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions bot added the stale Stale PRs label Nov 21, 2024
@github-actions
Copy link
Copy Markdown

This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.

@github-actions github-actions bot added the closed-stale PRs that were closed due to inactivity label Dec 22, 2024
@github-actions github-actions bot closed this Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closed-stale PRs that were closed due to inactivity stale Stale PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant