KAFKA-8748: Fix flaky testDescribeLogDirsRequest#7182
Merged
ijuma merged 1 commit intoapache:trunkfrom Aug 9, 2019
Merged
Conversation
…equest The introduction of KIP-480: Sticky Producer Partitioner had the side effect that `generateAndProduceMessages` can often write messages to a lower number of partitions to improve batching. `testDescribeLogDirsRequest` (and potentially other tests) relies on the messages being written somewhat uniformly to the topic partitions. We fix the issue by including a monotonically increasing key in the produced messages.
ijuma
changed the title
Member
Author
Member
Author
|
Two builds passed and one failed with the known flake |
ijuma
added a commit
to confluentinc/kafka
that referenced
this pull request
Aug 9, 2019
* apache-github/trunk: MINOR: Ignore dynamic log4j log level tests (apache#7183) KAFKA-8748: Fix flaky testDescribeLogDirsRequest (apache#7182) KAFKA-8598: Use automatic RPC generation in RenewDelegationToken KAFKA-8179: Part 3, Add PartitionsLost API for resetGenerations and metadata/subscription change (apache#6884)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The introduction of KIP-480: Sticky Producer Partitioner had the
side effect that
generateAndProduceMessagescan often writemessages to a lower number of partitions to improve batching.
testDescribeLogDirsRequest(and potentially other tests) relieson the messages being written somewhat uniformly to the topic
partitions. We fix the issue by including a monotonically
increasing key in the produced messages.
I also included a couple of minor clean-ups I noticed while
debugging the issue.
The test failed very frequently when executed locally before the
change and it passed 100 times consecutively after the change.
Committer Checklist (excluded from commit message)