Closed
Conversation
add support for reading and writing varlongs. Remove support for the functions that always checked null before serializing or deserializing because we're going to be more careful now (and complain about invalid nulls).
* Move default fields validation to write(). * Update MessageTest and get it passing.
Retcon the ControlledShutdownRequest v0 header as header 0, and the current version as v1. Create version 2 for headers that have tagged fields and compact strings.
* Fix AbstractResponse bug that led to incorrect response serialization * Expose data fields in RequestHeader and ResponseHeader.
* SchemaGenerator needs to take into account flexibleVersions overrides * Don't allow flexibleVersions overrides except for fields of string and bytes types.
IsNullConditional should not generate a version check. It creates too many conditionals. Now, we either use the maybeNull generator callback, or the definitely not null generator callback. On the same note, use Runnable instead of ClauseGenerator, since there is no need to pass in versions. VersionConditional: fix a bug where we would sometimes erroneosly generate a version check even when the two ranges didn't intersect. Lift the flexible versions check out of the loop when serializing arrays (unless the element type of the array would be serialized the same either way.) Fix the serialization of tagged field headers in Message#write.
* Add RawTaggedField#size * Fix the write and size functions for rawTaggedFields * In MessageTest, add testwriteNullForNonNullableFieldRaisesException and testUnknownTaggedFields
Add flexibleVersion to all message specs. Get rid of request header / response header v2 for now, until we can figure out what to do about ApiVersionsRequest / KIP-511 here.
These classes should not have hard-coded switch statements for different versions, but they do... fix that so our version bumps will work. ListGroupsRequest.json: fix a typo
Contributor
Author
|
See #7325 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.