Skip to content

KAFKA-8861 Fix flaky RegexSourceIntegrationTest.testMultipleConsumers…#7281

Merged
bbejeck merged 1 commit intoapache:trunkfrom
chia7712:KAFKA_8861
Sep 4, 2019
Merged

KAFKA-8861 Fix flaky RegexSourceIntegrationTest.testMultipleConsumers…#7281
bbejeck merged 1 commit intoapache:trunkfrom
chia7712:KAFKA_8861

Conversation

@chia7712
Copy link
Copy Markdown
Member

@chia7712 chia7712 commented Sep 3, 2019

similar to https://issues.apache.org/jira/browse/KAFKA-8011 and https://issues.apache.org/jira/browse/KAFKA-8026

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Copy Markdown
Member

@mjsax mjsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM.

Call for second review @guozhangwang @bbejeck @vvcephei @ableegoldman @cadonna @abbccdda

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Sep 3, 2019

Java 11 / 2.12 failed with env error. Java 11 / 2.13 and Java 8 passed.

Retest this please.

@mjsax mjsax added streams tests Test fixes (including flaky tests) labels Sep 3, 2019
@mjsax
Copy link
Copy Markdown
Member

mjsax commented Sep 3, 2019

Older branches are affected, too. The first fix (for same issue, different methods) when into 2.0 (but not 1.1) -- hence, we should only back-port to 2.0.

Copy link
Copy Markdown
Member

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @chia7712! LGTM.

@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Sep 3, 2019

retest this please

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Sep 3, 2019

Why did we need to retest, @bbejeck ?

@bbejeck bbejeck merged commit 18e6bb2 into apache:trunk Sep 4, 2019
@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Sep 4, 2019

Merged #7281 into trunk.

bbejeck pushed a commit that referenced this pull request Sep 4, 2019
…CanReadFromPartitionedTopic (#7281)

similar to https://issues.apache.org/jira/browse/KAFKA-8011 and https://issues.apache.org/jira/browse/KAFKA-8026

Reviewers:  Matthias J. Sax <mjsax@apache.org>,  Bill Bejeck <bbejeck@gmail.com>
bbejeck pushed a commit that referenced this pull request Sep 4, 2019
…CanReadFromPartitionedTopic (#7281)

similar to https://issues.apache.org/jira/browse/KAFKA-8011 and https://issues.apache.org/jira/browse/KAFKA-8026

Reviewers:  Matthias J. Sax <mjsax@apache.org>,  Bill Bejeck <bbejeck@gmail.com>
bbejeck pushed a commit that referenced this pull request Sep 4, 2019
…CanReadFromPartitionedTopic (#7281)

similar to https://issues.apache.org/jira/browse/KAFKA-8011 and https://issues.apache.org/jira/browse/KAFKA-8026

Reviewers:  Matthias J. Sax <mjsax@apache.org>,  Bill Bejeck <bbejeck@gmail.com>
bbejeck pushed a commit that referenced this pull request Sep 4, 2019
…CanReadFromPartitionedTopic (#7281)

similar to https://issues.apache.org/jira/browse/KAFKA-8011 and https://issues.apache.org/jira/browse/KAFKA-8026

Reviewers:  Matthias J. Sax <mjsax@apache.org>,  Bill Bejeck <bbejeck@gmail.com>
@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Sep 4, 2019

cherry-picked to 2.3, 2.2, 2.1 and 2.0

@chia7712 chia7712 deleted the KAFKA_8861 branch March 25, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

streams tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants