Skip to content

KAFKA-8913: Document topic based configs & ISR settings for Streams apps#7346

Merged
mjsax merged 1 commit intoapache:trunkfrom
vinothchandar:KAFKA-8913
Sep 18, 2019
Merged

KAFKA-8913: Document topic based configs & ISR settings for Streams apps#7346
mjsax merged 1 commit intoapache:trunkfrom
vinothchandar:KAFKA-8913

Conversation

@vinothchandar
Copy link
Copy Markdown
Member

  • Documented how to set topic based configs
  • Documented how to achieve MIN_IN_SYNC_REPLICAS_CONFIG = 2 for reliable apps

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

  - Documented how to set topic based configs
  - Documented how to achieve MIN_IN_SYNC_REPLICAS_CONFIG = 2 for reliable apps
@vinothchandar
Copy link
Copy Markdown
Member Author

Copy pasted these onto kafka-site and the site seems to work fine.

See box at the end of picture

Screen Shot 2019-09-17 at 5 17 18 PM

See right after "Same applied to ...."

Screen Shot 2019-09-17 at 5 17 08 PM

@mjsax Please take a look.. Also can you provide guidance on

  • backporting to older kafka releases?
  • Also sending a PR to kafka-site repo?

@mjsax mjsax merged commit 15d69b7 into apache:trunk Sep 18, 2019
mjsax pushed a commit that referenced this pull request Sep 18, 2019
…pps (#7346)

Reviewer: Matthias J. Sax <matthias@confluent.io>
mjsax pushed a commit that referenced this pull request Sep 18, 2019
…pps (#7346)

Reviewer: Matthias J. Sax <matthias@confluent.io>
mjsax pushed a commit that referenced this pull request Sep 18, 2019
…pps (#7346)

Reviewer: Matthias J. Sax <matthias@confluent.io>
mjsax pushed a commit that referenced this pull request Sep 18, 2019
…pps (#7346)

Reviewer: Matthias J. Sax <matthias@confluent.io>
@mjsax
Copy link
Copy Markdown
Member

mjsax commented Sep 18, 2019

Merged to trunk and cherry-picked to 2.3, 2.2, 2.1, and 2.0 (seems to be sufficient for me).

If you want the update on the website immediately, please do a PR against kafka-site -- otherwise, it would be effective only when we do a release an update the webpage. You would need to do the update for each release.

@vinothchandar
Copy link
Copy Markdown
Member Author

@mjsax thanks! To clarify, the next AK release will only update the latest version's doc right? we still need to update older releases?

if not, I am happy to wait for the release.

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Sep 19, 2019

Yes. If we release 2.3.1 only 2.3 docs are updated. If we release 2.4.0 only new 2.4 docs are added. Hence, a PR for the webpage should just update all versions for simplicity as we don't know exactly when a bug-fix release might update older docs.

mjsax pushed a commit to apache/kafka-site that referenced this pull request Sep 21, 2019
…231)

- Documented how to set topic based configs
- Documented how to achieve MIN_IN_SYNC_REPLICAS_CONFIG = 2 for reliable apps
- cf apache/kafka#7346

Reviewer: Matthias J. Sax <matthias@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants