KAFKA-8855; Collect and Expose Client's Name and Version in the Brokers (KIP-511 Part 1)#7381
Merged
cmccabe merged 4 commits intoapache:trunkfrom Oct 4, 2019
Conversation
dajac
commented
Sep 24, 2019
…rs (KIP-511 Part 1)
83a967a to
16602bf
Compare
Closed
3 tasks
mumrah
reviewed
Sep 27, 2019
mumrah
reviewed
Oct 1, 2019
cmccabe
reviewed
Oct 3, 2019
cmccabe
reviewed
Oct 3, 2019
cmccabe
reviewed
Oct 3, 2019
cmccabe
reviewed
Oct 3, 2019
cmccabe
reviewed
Oct 3, 2019
Contributor
|
Thanks, @dajac . This looks pretty close to being ready to go. I left a few comments. |
Member
Author
|
@cmccabe Thanks for the review. I have addressed all your comments. |
Contributor
|
LGTM |
Contributor
|
retest this please |
1 similar comment
Member
Author
|
retest this please |
Member
Author
|
Failing tests JDK 8 and Scala 2.11
JDK 11 and Scala 2.12
JDK 11 and Scala 2.13
They are unrelated to the changes made in this PR. |
Member
Author
|
I ran tests locally and got another failing test:
I wanted to confirm that the failing tests in CI are flaky ones. |
Contributor
|
Those tests pass for me locally. Committing |
|
hi my friend,i don't know why you have to "add ClientSoftwareName and ClientSoftwareVersions in the ApiVersionsRequest;"。 This does not seem to be a mandatory field to add. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the first part of KIP-511, namely:
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)