Skip to content

KAFKA-8944: Fixed KTable compiler warning.#7393

Merged
bbejeck merged 1 commit intoapache:trunkfrom
huxihx:KAFKA-8944
Oct 9, 2019
Merged

KAFKA-8944: Fixed KTable compiler warning.#7393
bbejeck merged 1 commit intoapache:trunkfrom
huxihx:KAFKA-8944

Conversation

@huxihx
Copy link
Copy Markdown
Contributor

@huxihx huxihx commented Sep 26, 2019

https://issues.apache.org/jira/browse/KAFKA-8944

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@mjsax mjsax added the streams label Sep 26, 2019
@mjsax
Copy link
Copy Markdown
Member

mjsax commented Sep 26, 2019

Call for review @bbejeck @vvcephei @abbccdda

@huxihx
Copy link
Copy Markdown
Contributor Author

huxihx commented Sep 26, 2019

retest this please.

@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Sep 26, 2019

Java 11/2.12 build timed out
Java 11/2.13 failed with ERROR: Error cloning remote repo 'origin'
Java 8/2.11 failed with

# There is insufficient memory for the Java Runtime Environment to continue.
# Cannot create GC thread. Out of system resources.

retest this please

Copy link
Copy Markdown
Member

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @huxihx. I checked out the PR and confirmed that compiler warning is gone and the streams-scala tests run.

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Oct 8, 2019

@huxihx Can you rebase this PR to resolve the merge conflicts?

@huxihx
Copy link
Copy Markdown
Contributor Author

huxihx commented Oct 9, 2019

@mjsax Please review again. Thanks

@bbejeck bbejeck merged commit 7c4b029 into apache:trunk Oct 9, 2019
@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Oct 9, 2019

Merged 7393 into trunk.

@huxihx huxihx deleted the KAFKA-8944 branch October 9, 2019 06:11
ijuma added a commit to ijuma/kafka that referenced this pull request Apr 28, 2020
…t-for-generated-requests

* apache-github/trunk:
  KAFKA-8932; Add tag for CreateTopicsResponse.TopicConfigErrorCode (KIP-525) (apache#7464)
  KAFKA-8944: Fixed KTable compiler warning. (apache#7393)
  KAFKA-8964: Rename tag client-id for thread-level metrics and below (apache#7429)
  MINOR: remove unused imports in Streams system tests (apache#7468)
  KAFKA-7190; Retain producer state until transactionalIdExpiration time passes (apache#7388)
  KAFKA-8983; AdminClient deleteRecords should not fail all partitions unnecessarily (apache#7449)
  MINOR: Modified Exception handling for KIP-470 (apache#7461)
  KAFKA-7245: Deprecate WindowStore#put(key, value) (apache#7105)
  KAFKA-8179: Part 7, cooperative rebalancing in Streams (apache#7386)
  KAFKA-8985; Add flexible version support to inter-broker APIs (apache#7453)
  MINOR: Bump version to 2.5.0-SNAPSHOT (apache#7455)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants