HOTFIX: don't throw if upgrading from very old versions#7436
Merged
guozhangwang merged 3 commits intoapache:trunkfrom Oct 2, 2019
Merged
HOTFIX: don't throw if upgrading from very old versions#7436guozhangwang merged 3 commits intoapache:trunkfrom
guozhangwang merged 3 commits intoapache:trunkfrom
Conversation
Contributor
|
Should we at least log the situation? otherwise lgtm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When upgrading from version before version probing, the
UPGRADE_FROMparameter is set and forces the used subscription version to stay at the associated older version until everyone is on the new.This means we might get a mix of new and old versions <
EARLIEST_PROBEABLE_VERSIONas we go through the second rolling bounce and remove theUPGRADE_FROMconfig. So we should just not do version probing if the version is too old, rather than throw an exception