Closed
Conversation
These fail often for me due to SSH connection loss
Member
Author
|
Trying this for RC1 of 2.3.1, saw this during most recent run: and the script continues on. |
ewencp
approved these changes
Oct 7, 2019
Contributor
ewencp
left a comment
ewencp
left a comment
There was a problem hiding this comment.
LGTM, just a few minor questions.
| cmd_arg = cmd_arg.split() | ||
|
|
||
| allow_failure = kwargs.pop("allow_failure", False) | ||
| num_retries = kwargs.pop("num_retries", 0) |
Contributor
There was a problem hiding this comment.
What kinds of failures are we trying to mask here? Frequently retries also require delays between retries.
Member
Author
There was a problem hiding this comment.
Added a sleep in the new PR
| kwargs['num_retries'] = num_retries - 1 | ||
| kwargs['allow_failure'] = allow_failure | ||
| print("Retrying... %d remaining retries" % (num_retries - 1)) | ||
| return cmd(action, cmd_arg, *args, **kwargs) |
Contributor
There was a problem hiding this comment.
Probably fine currently given max number of retries we specify, but would really be preferable to do this iteratively (which also doesn't require copying/mgmt of kwargs like this).
Member
|
@mumrah you may want to get this into trunk before the upcoming release. |
Member
Author
|
Closing in favor of #8021 which is based on trunk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add retry capability to the
cmdfunction in release.py. This allows for selectively retrying certain commands which might be flaky, like the SFTP puts.