Skip to content

Eagerly unmap during resize #7540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shikhar wants to merge 1 commit into from
Closed

Eagerly unmap during resize #7540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions core/src/main/scala/kafka/log/AbstractIndex.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,10 @@ abstract class AbstractIndex[K, V](@volatile var file: File, val baseOffset: Lon
try {
val position = mmap.position()

/* Windows won't let us modify the file length while the file is mmapped :-( */
if (OperatingSystem.IS_WINDOWS)
safeForceUnmap()
// Necessary on Windows, file length cannot be modified without unmapping
// Also, generally a good practice to eagerly unmap rather than leave it to GC (KAFKA-4614)
safeForceUnmap()

raf.setLength(roundedNewSize)
_length = roundedNewSize
mmap = raf.getChannel().map(FileChannel.MapMode.READ_WRITE, 0, roundedNewSize)
Expand Down