Merged
Conversation
Member
Author
|
ping @guozhangwang and @ableegoldman for review |
Member
Author
|
kicked off branch builder https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3193/ |
ableegoldman
approved these changes
Oct 18, 2019
| + (args.length > 1 ? args[1] : "")); | ||
| if (args.length < 2) { | ||
| System.err.println("StreamsUpgradeToCooperativeRebalanceTest requires two arguments (zookeeper-url, properties-file) but only " + args.length + " provided: " | ||
| + (args.length > 0 ? args[0] + " " : "")); |
Member
There was a problem hiding this comment.
Just wondering, why the extra space after args[0]?
Member
Author
There was a problem hiding this comment.
Didn't notice that before, I'll clean it up.
Member
Author
|
updated this |
Contributor
guozhangwang
left a comment
guozhangwang
left a comment
There was a problem hiding this comment.
Thanks for the cleanup @bbejeck , wondering if we can do the same cleanup for StreamsUpgradeTest?
Otherwise, LGTM
Member
Author
@guozhangwang ack, I'll do a follow-on PR for this. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)