Skip to content

KAFKA-9080: Addresses MessageFormatChangeTest.testCompatibilty with version 0.9.0.1 #7628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tuvtran wants to merge 3 commits into from
Closed

KAFKA-9080: Addresses MessageFormatChangeTest.testCompatibilty with version 0.9.0.1 #7628

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
def0713
add check for version
Oct 31, 2019
b14a549
Revert "add check for version"
Nov 1, 2019
b9bfc2e
remove check in assignOffsetNonCompressed
Nov 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions core/src/main/scala/kafka/log/LogValidator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,6 @@ private[kafka] object LogValidator extends Logging {
magic: Byte,
brokerTopicStats: BrokerTopicStats): ValidationAndOffsetAssignResult = {
var maxTimestamp = RecordBatch.NO_TIMESTAMP
val expectedInnerOffset = new LongRef(0)
var offsetOfMaxTimestamp = -1L
val initialOffset = offsetCounter.value

Expand All @@ -251,16 +250,6 @@ private[kafka] object LogValidator extends Logging {
for ((record, batchIndex) <- batch.asScala.view.zipWithIndex) {
validateRecord(batch, topicPartition, record, batchIndex, now, timestampType, timestampDiffMaxMs, compactedTopic, brokerTopicStats)

val expectedOffset = expectedInnerOffset.getAndIncrement()

// inner records offset should always be continuous
if (record.offset != expectedOffset) {
brokerTopicStats.allTopicsStats.invalidOffsetOrSequenceRecordsPerSec.mark()
throw new RecordValidationException(
new InvalidRecordException(s"Inner record $record inside the compressed record batch does not have incremental offsets, expected offset is $expectedOffset in topic partition $topicPartition."),
List(new RecordError(batchIndex)))
}

val offset = offsetCounter.getAndIncrement()
if (batch.magic > RecordBatch.MAGIC_VALUE_V0 && record.timestamp > maxBatchTimestamp) {
maxBatchTimestamp = record.timestamp
Expand Down