Skip to content

HOTFIX: fix bug in VP test where it greps for the wrong log message#7642

Merged
guozhangwang merged 2 commits intoapache:2.4from
ableegoldman:HOTFIX-fix-message-in-VP-system-test
Nov 5, 2019
Merged

HOTFIX: fix bug in VP test where it greps for the wrong log message#7642
guozhangwang merged 2 commits intoapache:2.4from
ableegoldman:HOTFIX-fix-message-in-VP-system-test

Conversation

@ableegoldman
Copy link
Copy Markdown
Member

@ableegoldman ableegoldman commented Nov 4, 2019

We added more version info to the log messages but must not have cleanly backported the test update -- looking back it seems like older versions might also need a fix (separate PR as the version numbers are different in 2.1-2.3)

PR for 2.1-2.3: #7643

@ableegoldman
Copy link
Copy Markdown
Member Author

ableegoldman commented Nov 4, 2019

Here's a system test run (one should be sufficient as the error would have caused 100% failure rate): https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3386

@guozhangwang
Copy link
Copy Markdown
Contributor

@ableegoldman
Copy link
Copy Markdown
Member Author

ableegoldman commented Nov 4, 2019

Caught another test fix (not actual bug) that was fixed in trunk but slipped from 2.4 -- StreamsUpgradeTest messes around with constructing its own new Subscription objects and needs to encode the ownedPartitions that are normally encoded by the ConsumerCoordinator (KAFKA-9134 strikes again)

@ableegoldman
Copy link
Copy Markdown
Member Author

@guozhangwang guozhangwang merged commit 6fc17bc into apache:2.4 Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

streams tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants