KAFKA-9353: Add groupInstanceId to DescribeGroup for better visibility#7886
KAFKA-9353: Add groupInstanceId to DescribeGroup for better visibility#7886hachikuji merged 1 commit intoapache:trunkfrom
Conversation
|
@abbccdda PTAL. |
|
The columns don't line up nicely for me when there is no group instance id: |
|
Thanks for the PR @dengziming. I think the change makes sense, could you also address @WheresAlice comment? |
7d42c30 to
70888bd
Compare
|
@WheresAlice thank you. this is because of the default column width is 15, but len("GROUP-INSTANCE-ID")=17, so I just change it to 17, and it's better now: @abbccdda take a look again. |
|
Yes, that's looking better to me too: LGTM |
abbccdda
left a comment
There was a problem hiding this comment.
Thanks for the patch, LGTM! Will ping @hachikuji if he has time to take another look
70888bd to
c8e5957
Compare
|
@ijuma Hi, PTLA. when at least one column is not null |
c8e5957 to
0f7f75b
Compare
|
@hachikuji hi, resolved, PTAL. |
|
cc @hachikuji , PTAL. |
hachikuji
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the patch!
|
retest this please |
|
Retest this please. |
Kafka-8538(#6957) has already added
group.instance.idtoMemberDescriptionbut didn't print it, so we just print it.before the change, the describe command print as follows:
after the change, the describe command print as follows:
if all the
GROUP-INSTANCE-IDis null, just as the previous: