Skip to content

KAFKA-9407: Return Immutable List from SchemaSourceTask#7939

Merged
kkonstantine merged 1 commit intoapache:trunkfrom
belugabehr:KAFKA-9407
Mar 24, 2020
Merged

KAFKA-9407: Return Immutable List from SchemaSourceTask#7939
kkonstantine merged 1 commit intoapache:trunkfrom
belugabehr:KAFKA-9407

Conversation

@belugabehr
Copy link
Copy Markdown
Contributor

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@rondagostino
Copy link
Copy Markdown
Contributor

LGTM

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Jan 28, 2020

ok to test

@kkonstantine
Copy link
Copy Markdown
Contributor

retest this please

@kkonstantine
Copy link
Copy Markdown
Contributor

Only the two flaky test cases in
org.apache.kafka.streams.integration.StandbyTaskEOSIntegrationTest.surviveWithOneTaskAsStandby failed, that are now now fixed by: #8330

I'll skip rebuilding this RP and will merge only to trunk.

Copy link
Copy Markdown
Contributor

@kkonstantine kkonstantine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkonstantine kkonstantine merged commit 99eb0d1 into apache:trunk Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants