KAFKA-9428: Add KeyQueryMetadata APIs to KafkaStreams#7960
KAFKA-9428: Add KeyQueryMetadata APIs to KafkaStreams#7960vvcephei wants to merge 1 commit intoapache:trunkfrom vvcephei:kafka-6144-key-query-metadata
Conversation
vvcephei
changed the title
|
@vinothchandar & @brary, This is the first chunk from your PR #7868, which I reviewed and feel good about merging. Unless you have any objections, I'll go ahead and merge it once the tests (and system tests) pass. |
| inputValuesKeys, | ||
| storeName + "-" + streamThree, | ||
| DEFAULT_TIMEOUT_MS); | ||
| DEFAULT_TIMEOUT_MS, |
There was a problem hiding this comment.
should we also move over the standby querying test from the original PR? I did not see any other test covering querying with standby replication.. @vvcephei ?
There was a problem hiding this comment.
Thanks for pointing this out, @vinothchandar .
The ability to query standbys (and hence this test) is part of the follow-up PR: #7962
vinothchandar
left a comment
vinothchandar
left a comment
There was a problem hiding this comment.
LGTM.. matched with #7868 fully once
| @@ -700,6 +711,7 @@ private Map<String, Assignment> computeNewAssignment(final Map<UUID, ClientMetad | |||
| clientMetadata, | |||
| partitionsForTask, | |||
| partitionsByHostState, | |||
There was a problem hiding this comment.
may be rename partitionsByHostState in other places too?
cosmetic change. your call
There was a problem hiding this comment.
I'm going to skip this for now, since it's ready to merge.
Deprecate existing metadata query APIs in favor of new ones that include standby hosts as well as partition information. Implements: KIP-535 Co-authored-by: Navinder Pal Singh Brar <navinder_brar@yahoo.com> Reviewed-by: John Roesler <vvcephei@apache.org>
3 participants
Committer Checklist (excluded from commit message)