Skip to content

KAFKA-9462: Correct exception message in DistributedHerder#7995

Merged
rhauch merged 1 commit intoapache:trunkfrom
tedyu:dist-herder
Jan 24, 2020
Merged

KAFKA-9462: Correct exception message in DistributedHerder#7995
rhauch merged 1 commit intoapache:trunkfrom
tedyu:dist-herder

Conversation

@tedyu
Copy link
Copy Markdown
Contributor

@tedyu tedyu commented Jan 22, 2020

There are a few exception messages in DistributedHerder which were copied from other exception message.

This PR corrects the messages to reflect actual condition

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@tedyu
Copy link
Copy Markdown
Contributor Author

tedyu commented Jan 23, 2020

ping @mjsax for review

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Jan 23, 2020

This is a Kafka Connect PR. I leave it to @rhauch to review and merge.

@mjsax mjsax added the connect label Jan 23, 2020
Copy link
Copy Markdown
Contributor

@rhauch rhauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @tedyu . While one of the changes in this PR makes sense, I'm not sure the other two do.

Copy link
Copy Markdown
Contributor

@rhauch rhauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @tedyu!

@rhauch rhauch merged commit 8e5faca into apache:trunk Jan 24, 2020
ijuma added a commit to confluentinc/kafka that referenced this pull request Jan 25, 2020
Conflicts and/or compiler errors due to the fact that we
temporarily reverted the commit that removes
Scala 2.11 support:

* Exit.scala: replace SAMs with anonymous inner classes.
* MiniKdc.scala: take upstream changes.

# By A. Sophie Blee-Goldman (1) and others
# Via Jason Gustafson
* apache-github/trunk:
  KAFKA-9254; Overridden topic configs are reset after dynamic default change (apache#7870)
  MINOR: MiniKdc JVM shutdown hook fix (apache#7946)
  KAFKA-9152; Improve Sensor Retrieval (apache#7928)
  Correct exception message in DistributedHerder (apache#7995)
  KAFKA-7317: Use collections subscription for main consumer to reduce metadata (apache#7969)
  KAFKA-9181; Maintain clean separation between local and group subscriptions in consumer's SubscriptionState (apache#7941)
  KAFKA-7737; Use single path in producer for initializing the producerId (apache#7920)

# Conflicts:
#	core/src/test/scala/kafka/security/minikdc/MiniKdc.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants