Skip to content

KAFKA-9477 Document RoundRobinAssignor as an option for partition.assignment.strategy#8007

Merged
cmccabe merged 4 commits intoapache:trunkfrom
arodoni:RoundRobinAssignor
Feb 4, 2020
Merged

KAFKA-9477 Document RoundRobinAssignor as an option for partition.assignment.strategy#8007
cmccabe merged 4 commits intoapache:trunkfrom
arodoni:RoundRobinAssignor

Conversation

@arodoni
Copy link
Copy Markdown
Contributor

@arodoni arodoni commented Jan 28, 2020 •
edited
Loading

JIRA: https://issues.apache.org/jira/browse/KAFKA-9477

Summary: Add RoundRobinAssignor as an option to consumer configs

@joel-hamill

@arodoni arodoni requested review from guozhangwang and mjsax January 28, 2020 00:25
@mjsax
Copy link
Copy Markdown
Member

mjsax commented Jan 28, 2020

\cc @hachikuji @cmccabe For review.

@arodoni arodoni requested review from cmccabe and hachikuji and removed request for guozhangwang and mjsax January 29, 2020 19:55
@cmccabe
Copy link
Copy Markdown
Contributor

cmccabe commented Jan 31, 2020

Can you please add line breaks to avoid going over 100 characters in each line? Looks good aside from that.

@arodoni
Copy link
Copy Markdown
Contributor Author

arodoni commented Feb 3, 2020

@cmccabe @hachikuji Could you please review the latest changes, approve, and merge them? Thank you.

@cmccabe cmccabe changed the title KAFKA-9477 Add RoundRobinAssignor as an option to Consumer Configs KAFKA-9477 Document RoundRobinAssignor as an option for partition.assignment.strategy Feb 4, 2020
@cmccabe
Copy link
Copy Markdown
Contributor

cmccabe commented Feb 4, 2020

LGTM

@cmccabe cmccabe merged commit 7748fc2 into apache:trunk Feb 4, 2020
@arodoni arodoni deleted the RoundRobinAssignor branch February 4, 2020 18:07
@chia7712
Copy link
Copy Markdown
Member

chia7712 commented Feb 4, 2020

@cmccabe

seems this patch causes the checkstyle error.

> Task :clients:checkstyleMain
[ant:checkstyle] [ERROR] C:\Users\chia7712\kafka\clients\src\main\java\org\apache\kafka\clients\consumer\ConsumerConfig.java:106:109: '+' is not preceded with whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] C:\Users\chia7712\kafka\clients\src\main\java\org\apache\kafka\clients\consumer\ConsumerConfig.java:107:72: '+' is not preceded with whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] C:\Users\chia7712\kafka\clients\src\main\java\org\apache\kafka\clients\consumer\ConsumerConfig.java:108:75: '+' is not preceded with whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] C:\Users\chia7712\kafka\clients\src\main\java\org\apache\kafka\clients\consumer\ConsumerConfig.java:109:77: '+' is not preceded with whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] C:\Users\chia7712\kafka\clients\src\main\java\org\apache\kafka\clients\consumer\ConsumerConfig.java:110:73: '+' is not preceded with whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] C:\Users\chia7712\kafka\clients\src\main\java\org\apache\kafka\clients\consumer\ConsumerConfig.java:112:80: '+' is not preceded with whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] C:\Users\chia7712\kafka\clients\src\main\java\org\apache\kafka\clients\consumer\ConsumerConfig.java:113:77: '+' is not preceded with whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] C:\Users\chia7712\kafka\clients\src\main\java\org\apache\kafka\clients\consumer\ConsumerConfig.java:115:80: '+' is not preceded with whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] C:\Users\chia7712\kafka\clients\src\main\java\org\apache\kafka\clients\consumer\ConsumerConfig.java:116:74: '+' is not preceded with whitespace. [WhitespaceAround]

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Feb 5, 2020

The jenkins build should have detected this -- did we merge this even if the build failed?

ijuma added a commit to confluentinc/kafka that referenced this pull request Feb 7, 2020
@ijuma
CONFLUENT: Sync from apache/kafka (7 February 2020)
a8ca14b 
Conflicts:
* build.gradle: moved avro plugin definition below
newly added test retry plugin.

* apache-github/trunk:
  MINOR: further InternalTopologyBuilder cleanup  (apache#8046)
  MINOR: Add timer for update limit offsets (apache#8047)
  HOTFIX: Fix spotsbug failure in Kafka examples (apache#8051)
  KAFKA-9447: Add new customized EOS model example (apache#8031)
  KAFKA-8164: Add support for retrying failed (apache#8019)
  HOTFIX: checkstyle for newly added unit test
  KAFKA-9261; Client should handle unavailable leader metadata (apache#7770)
  MINOR: Fix typos introduced in KIP-559 (apache#8042)
  MINOR: Fixing null handilg in ValueAndTimestampSerializer (apache#7679)
  KAFKA-9113: Clean up task management and state management (apache#7997)
  MINOR: fix checkstyle issue in ConsumerConfig.java (apache#8038)
  KAFKA-9491; Increment high watermark after full log truncation (apache#8037)
  KAFKA-9477 Document RoundRobinAssignor as an option for partition.assignment.strategy (apache#8007)
  KAFKA-9074: Correct Connect’s `Values.parseString` to properly parse a time and timestamp literal (apache#7568)
  KAFKA-9492; Ignore record errors in ProduceResponse for older versions (apache#8030)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmccabe cmccabe Awaiting requested review from cmccabe

@hachikuji hachikuji Awaiting requested review from hachikuji

Assignees

No one assigned

Labels

consumer docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arodoni @mjsax @cmccabe @chia7712