KAFKA-9494: Include data type of the config in ConfigEntry#8034
Closed
srpanwar-confluent wants to merge 1 commit intoapache:trunkfrom
Closed
KAFKA-9494: Include data type of the config in ConfigEntry#8034srpanwar-confluent wants to merge 1 commit intoapache:trunkfrom
srpanwar-confluent wants to merge 1 commit intoapache:trunkfrom
Conversation
| val readOnly = !DynamicBrokerConfig.AllDynamicConfigs.contains(name) | ||
| new DescribeConfigsResponse.ConfigEntry(name, valueAsString, source, isSensitive, readOnly, synonyms.asJava) | ||
| new DescribeConfigsResponse.ConfigEntry( | ||
| name, valueAsString, source, isSensitive, readOnly, synonyms.asJava, configEntryType.toString()) |
Contributor
Author
There was a problem hiding this comment.
Check for null
Contributor
|
Is there a KIP for this? Unless I am mistaken, the |
Contributor
Author
|
@rondagostino I am in the process of writing the KIP. I'll update the PR and move it out of draft stage once its ready. |
Member
|
@srpanwar-confluent you should probably we aware of #8312, which converts the DescribeConfigs RPC to use the generated protocols. |
Contributor
Author
|
thanks @tombentley for the heads up. I'll wait for your changes to go merge before resuming work on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change?
To enable better validation. Including the data type can significantly improve client's(web or cli or any other client) ability to validate the values before even making a request to Kafka. In the absence of
typethe only way to know if the user specified value is correct is to make analtercall and check if there is no error.Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Updated and added new unit tests
Committer Checklist (excluded from commit message)