MINOR: Update schema field names in DescribeAcls Request/Response#8075
Closed
omkreddy wants to merge 1 commit intoapache:trunkfrom
Closed
MINOR: Update schema field names in DescribeAcls Request/Response#8075omkreddy wants to merge 1 commit intoapache:trunkfrom
omkreddy wants to merge 1 commit intoapache:trunkfrom
Conversation
Contributor
Author
Member
|
@omkreddy I don't see json name changes in that PR. |
omkreddy
changed the title
Contributor
Author
Yes, There were no json name changes in that PR. The field names in the json file differs from previous implementation. Even though field names are not part of protocol, I propose to update field names to maintain consistency. |
omkreddy
force-pushed
the
KAFKA-9026-Fix
branch
from
77dd459 to
e450a2d
Compare
Contributor
Author
|
Updated the schema field names to match with DeleteACL request/response schema field names. |
Contributor
|
LGTM |
Contributor
Author
|
@cmccabe Thanks for the review. test failures are not related. Merging to trunk and 2.5. |
omkreddy
added a commit
that referenced
this pull request
Feb 10, 2020
Author: Manikumar Reddy <manikumar.reddy@gmail.com> Reviewers: Ismael Juma <ismael@juma.me.uk>, Colin Patrick McCabe <cmccabe@apache.org> Closes #8075 from omkreddy/KAFKA-9026-Fix (cherry picked from commit 41fdae3) Signed-off-by: Manikumar Reddy <manikumar@confluent.io>
stanislavkozlovski
pushed a commit
to stanislavkozlovski/kafka
that referenced
this pull request
Feb 18, 2020
Author: Manikumar Reddy <manikumar.reddy@gmail.com> Reviewers: Ismael Juma <ismael@juma.me.uk>, Colin Patrick McCabe <cmccabe@apache.org> Closes apache#8075 from omkreddy/KAFKA-9026-Fix (cherry picked from commit 41fdae3) Signed-off-by: Manikumar Reddy <manikumar@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)