Skip to content

KAFKA-9181; Maintain clean separation between local and group subscriptions in consumer's SubscriptionState (#7941)#8084

Merged
hachikuji merged 1 commit intoapache:2.3from
soondenana:cherry-pick_a565d1a1
Feb 11, 2020
Merged

KAFKA-9181; Maintain clean separation between local and group subscriptions in consumer's SubscriptionState (#7941)#8084
hachikuji merged 1 commit intoapache:2.3from
soondenana:cherry-pick_a565d1a1

Conversation

@soondenana
Copy link
Copy Markdown
Contributor

Reviewers: Jason Gustafson jason@confluent.io, Guozhang Wang wangguoz@gmail.com
(cherry picked from commit a565d1a)

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

…ptions in consumer's SubscriptionState (apache#7941)

Reviewers: Jason Gustafson <jason@confluent.io>, Guozhang Wang <wangguoz@gmail.com>
(cherry picked from commit a565d1a)
@soondenana
Copy link
Copy Markdown
Contributor Author

Had conflicts in suppressions.xml and ConsumerCoordinatorTest.java.

@hachikuji
Copy link
Copy Markdown
Contributor

ok to test

Copy link
Copy Markdown
Contributor

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hachikuji hachikuji merged commit c7015ac into apache:2.3 Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants