Skip to content

KAFKA-6607: Commit correct offsets for transactional input data#8091

Merged
mjsax merged 2 commits intoapache:trunkfrom
mjsax:kafka-6607-eos-commit-trunk
Feb 12, 2020
Merged

KAFKA-6607: Commit correct offsets for transactional input data#8091
mjsax merged 2 commits intoapache:trunkfrom
mjsax:kafka-6607-eos-commit-trunk

Conversation

@mjsax
Copy link
Copy Markdown
Member

@mjsax mjsax commented Feb 11, 2020

Port of #8040 to trunk -- the only real difference is the missing check of we are in pending shutdown and a task is not found -- in trunk we always create all new task hence this check is not necessary.

\cc @guozhangwang

Copy link
Copy Markdown
Contributor

@guozhangwang guozhangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! In trunk we can be stricter and throw illegal-state since we should always have the tasks at hand still.

@mjsax mjsax force-pushed the kafka-6607-eos-commit-trunk branch from 491261e to a4d6a8e Compare February 12, 2020 04:35
@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Feb 12, 2020

Rebased this PR to resolve merge conflicts.

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Feb 12, 2020

Java 8 passed.
Java 11: kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

Retest this please.

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Feb 12, 2020

Java 8:

kafka.admin.DeleteConsumerGroupsTest.testDeleteWithMixOfSuccessAndError
kafka.admin.DescribeConsumerGroupTest.testDescribeGroupWithShortInitializationTimeout
kafka.admin.ResetConsumerGroupOffsetTest.testResetOffsetsAllTopicsAllGroups
kafka.admin.DescribeConsumerGroupTest.testDescribeGroupMembersWithShortInitializationTimeout
kafka.admin.DeleteConsumerGroupsTest.testDeleteCmdWithMixOfSuccessAndError

Java 11: kafka.admin.DescribeConsumerGroupTest.testDescribeGroupWithShortInitializationTimeout

Those are different test than in the run before. Merging this.

@mjsax mjsax merged commit aa0d0ec into apache:trunk Feb 12, 2020
@mjsax mjsax deleted the kafka-6607-eos-commit-trunk branch February 12, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants