KAFKA-6607: Commit correct offsets for transactional input data#8091
Merged
mjsax merged 2 commits intoapache:trunkfrom Feb 12, 2020
Merged
KAFKA-6607: Commit correct offsets for transactional input data#8091mjsax merged 2 commits intoapache:trunkfrom
mjsax merged 2 commits intoapache:trunkfrom
Conversation
guozhangwang
approved these changes
Feb 11, 2020
Contributor
guozhangwang
left a comment
There was a problem hiding this comment.
LGTM! In trunk we can be stricter and throw illegal-state since we should always have the tasks at hand still.
491261e to
a4d6a8e
Compare
Member
Author
|
Rebased this PR to resolve merge conflicts. |
Member
Author
|
Java 8 passed. Retest this please. |
Member
Author
|
Java 8: Java 11: Those are different test than in the run before. Merging this. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #8040 to
trunk-- the only real difference is the missing check of we are in pending shutdown and a task is not found -- intrunkwe always create all new task hence this check is not necessary.\cc @guozhangwang