KAFKA-9541:Flaky Test DescribeConsumerGroupTest#testDescribeGroupMembersWithShortInitializationTimeout#8094
Closed
huxihx wants to merge 3 commits intoapache:trunkfrom
Closed
KAFKA-9541:Flaky Test DescribeConsumerGroupTest#testDescribeGroupMembersWithShortInitializationTimeout#8094huxihx wants to merge 3 commits intoapache:trunkfrom
huxihx wants to merge 3 commits intoapache:trunkfrom
Conversation
added 2 commits
February 12, 2020 12:26
Occasionally the captured exception is DisconnectedException instead of TimeoutException. That might be due to an unexpected long pause that caused the node disconnection. We could simply ignore such cases.
Contributor
Author
|
@hachikuji Please review the patch. Thanks. |
abbccdda
reviewed
Feb 12, 2020
abbccdda
left a comment
There was a problem hiding this comment.
Could we catch the disconnected exception and retry for timeout exception, so that the test could fail on timeout eventually?
3 tasks
3 tasks
Contributor
|
Thanks for the PR. We fixed this with a different approach here: 2df7ea5. Basically we changed KafkaAdminClient so that it raises TimeoutException consistently. I will go ahead and close this. Please reopen if this was a mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/KAFKA-9541
Occasionally the captured exception is DisconnectedException instead of TimeoutException. That might be due to an unexpected long pause that caused the node disconnection.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)