Skip to content

KAFKA-9541:Flaky Test DescribeConsumerGroupTest#testDescribeGroupMembersWithShortInitializationTimeout#8094

Closed
huxihx wants to merge 3 commits intoapache:trunkfrom
huxihx:KAFKA-9541
Closed

KAFKA-9541:Flaky Test DescribeConsumerGroupTest#testDescribeGroupMembersWithShortInitializationTimeout#8094
huxihx wants to merge 3 commits intoapache:trunkfrom
huxihx:KAFKA-9541

Conversation

@huxihx
Copy link
Copy Markdown
Contributor

@huxihx huxihx commented Feb 12, 2020

https://issues.apache.org/jira/browse/KAFKA-9541

Occasionally the captured exception is DisconnectedException instead of TimeoutException. That might be due to an unexpected long pause that caused the node disconnection.

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

huxihx added 2 commits February 12, 2020 12:26
Occasionally the captured exception is DisconnectedException instead of TimeoutException. That might be due to an unexpected long pause that caused the node disconnection. We could simply ignore such cases.
@huxihx
Copy link
Copy Markdown
Contributor Author

huxihx commented Feb 12, 2020

@hachikuji Please review the patch. Thanks.

Copy link
Copy Markdown

@abbccdda abbccdda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we catch the disconnected exception and retry for timeout exception, so that the test could fail on timeout eventually?

@hachikuji
Copy link
Copy Markdown
Contributor

Thanks for the PR. We fixed this with a different approach here: 2df7ea5. Basically we changed KafkaAdminClient so that it raises TimeoutException consistently. I will go ahead and close this. Please reopen if this was a mistake.

@hachikuji hachikuji closed this Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants