Skip to content

KAFKA-9544; Fix flaky test AdminClientTest.testDefaultApiTimeoutOverride #8101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hachikuji merged 1 commit into from
Feb 19, 2020
Merged

KAFKA-9544; Fix flaky test AdminClientTest.testDefaultApiTimeoutOverride #8101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2631,11 +2631,14 @@ private void testApiTimeout(int requestTimeoutMs,
// Wait for the request to be timed out before backing off
TestUtils.waitForCondition(() -> !env.kafkaClient().hasInFlightRequests(),
"Timed out waiting for inFlightRequests to be timed out");
time.sleep(retryBackoffMs);

// Since api timeout bound is not hit, AdminClient should retry
TestUtils.waitForCondition(() -> env.kafkaClient().hasInFlightRequests(),
"Timed out waiting for Metadata request to be sent");
TestUtils.waitForCondition(() -> {
boolean hasInflightRequests = env.kafkaClient().hasInFlightRequests();
if (!hasInflightRequests)
time.sleep(retryBackoffMs);
return hasInflightRequests;
}, "Timed out waiting for Metadata request to be sent");
time.sleep(requestTimeoutMs + 1);

TestUtils.assertFutureThrows(result.future, TimeoutException.class);
Expand Down