KAFKA-9472: Remove deleted Connect tasks from status store#8118
Merged
kkonstantine merged 4 commits intoapache:trunkfrom May 25, 2020
Merged
KAFKA-9472: Remove deleted Connect tasks from status store#8118kkonstantine merged 4 commits intoapache:trunkfrom
kkonstantine merged 4 commits intoapache:trunkfrom
Conversation
Contributor
Author
|
@ncliang @gharris1727, would either you mind taking a look when you have a chance? |
ncliang
approved these changes
Mar 2, 2020
Contributor
ncliang
left a comment
ncliang
left a comment
There was a problem hiding this comment.
Very concise change. Just one question about the integration test, otherwise LGTM.
Contributor
Author
|
Thanks for the review, @ncliang! @rhauch @kkonstantine would you mind taking a look when you have a chance? |
Contributor
|
ok to test |
Contributor
|
retest this please |
Contributor
kkonstantine
left a comment
kkonstantine
left a comment
There was a problem hiding this comment.
Looks good. Thanks @C0urante.
One comment on the javadoc, aiming to keep it similar to the other javadocs.
Contributor
|
ok to test |
Contributor
|
retest this please |
Contributor
|
jdk11 succeeded, and previously jdk8 |
kkonstantine
changed the title
kkonstantine
pushed a commit
that referenced
this pull request
May 25, 2020
Although the statuses for tasks are removed from the status store when their connector is deleted, their statuses are not removed when only the task is deleted, which happens in the case that the number of tasks for a connector is reduced. This commit adds logic for deleting the statuses for those tasks from the status store whenever a rebalance has completed and the leader of a distributed cluster has detected that there are recently-deleted tasks. Standalone is also updated to accomplish this. Unit tests for the `DistributedHerder` and `StandaloneHerder` classes are updated and an integration test has been added. Reviewers: Nigel Liang <nigel@nigelliang.com>, Konstantine Karantasis <konstantine@confluent.io>
kkonstantine
pushed a commit
that referenced
this pull request
May 25, 2020
Although the statuses for tasks are removed from the status store when their connector is deleted, their statuses are not removed when only the task is deleted, which happens in the case that the number of tasks for a connector is reduced. This commit adds logic for deleting the statuses for those tasks from the status store whenever a rebalance has completed and the leader of a distributed cluster has detected that there are recently-deleted tasks. Standalone is also updated to accomplish this. Unit tests for the `DistributedHerder` and `StandaloneHerder` classes are updated and an integration test has been added. Reviewers: Nigel Liang <nigel@nigelliang.com>, Konstantine Karantasis <konstantine@confluent.io>
kkonstantine
pushed a commit
that referenced
this pull request
May 25, 2020
Although the statuses for tasks are removed from the status store when their connector is deleted, their statuses are not removed when only the task is deleted, which happens in the case that the number of tasks for a connector is reduced. This commit adds logic for deleting the statuses for those tasks from the status store whenever a rebalance has completed and the leader of a distributed cluster has detected that there are recently-deleted tasks. Standalone is also updated to accomplish this. Unit tests for the `DistributedHerder` and `StandaloneHerder` classes are updated and an integration test has been added. Reviewers: Nigel Liang <nigel@nigelliang.com>, Konstantine Karantasis <konstantine@confluent.io>
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
Although the statuses for tasks are removed from the status store when their connector is deleted, their statuses are not removed when only the task is deleted, which happens in the case that the number of tasks for a connector is reduced.
These changes add logic for deleting the statuses for those tasks from the status store whenever a rebalance has completed and the leader of a distributed cluster has detected that there are recently-deleted tasks. Standalone is also updated to accomplish this.
Unit tests for the
DistributedHerderandStandaloneHerderclasses are updated, and an integration test has been added.