[KAFKA-9563] Fix Kafka connect consumer and producer override docs#8124
Merged
kkonstantine merged 2 commits intoapache:trunkfrom Mar 23, 2020
Merged
[KAFKA-9563] Fix Kafka connect consumer and producer override docs#8124kkonstantine merged 2 commits intoapache:trunkfrom
kkonstantine merged 2 commits intoapache:trunkfrom
Conversation
Contributor
kkonstantine
left a comment
kkonstantine
left a comment
There was a problem hiding this comment.
Thanks for the PR @blcksrx !
Indeed this paragraph needs improvement and the producer.override. and consumer.override. prefixes are missing. But the replacement is not at the right place. The global prefixes producer. and consumer. can still be used in the workers configuration.
I added a suggested change to your one line change. Lmk what you think
Co-Authored-By: Konstantine Karantasis <konstantine@confluent.io>
kkonstantine
approved these changes
Mar 23, 2020
Contributor
kkonstantine
left a comment
kkonstantine
left a comment
There was a problem hiding this comment.
Thanks for the fix and the quick turnaround @blcksrx !
LGTM
Contributor
|
ok to test |
Contributor
|
The builder failed with the known broken test This is a documentation only improvement, so based on this run I'm merging this PR. |
kkonstantine
pushed a commit
that referenced
this pull request
Mar 23, 2020
…cer overrides (#8124) Kafka Connect main doc required a fix to distinguish between worker level producer and consumer overrides and per-connector level producer and consumer overrides, after the latter were introduced with KIP-458. * [KAFKA-9563] Fix Kafka connect consumer and producer override documentation Co-authored-by: Konstantine Karantasis <konstantine@confluent.io> Reviewers: Konstantine Karantasis <konstantine@confluent.io>
kkonstantine
pushed a commit
that referenced
this pull request
Mar 23, 2020
…cer overrides (#8124) Kafka Connect main doc required a fix to distinguish between worker level producer and consumer overrides and per-connector level producer and consumer overrides, after the latter were introduced with KIP-458. * [KAFKA-9563] Fix Kafka connect consumer and producer override documentation Co-authored-by: Konstantine Karantasis <konstantine@confluent.io> Reviewers: Konstantine Karantasis <konstantine@confluent.io>
kkonstantine
pushed a commit
that referenced
this pull request
Mar 23, 2020
…cer overrides (#8124) Kafka Connect main doc required a fix to distinguish between worker level producer and consumer overrides and per-connector level producer and consumer overrides, after the latter were introduced with KIP-458. * [KAFKA-9563] Fix Kafka connect consumer and producer override documentation Co-authored-by: Konstantine Karantasis <konstantine@confluent.io> Reviewers: Konstantine Karantasis <konstantine@confluent.io>
qq619618919
pushed a commit
to qq619618919/kafka
that referenced
this pull request
May 12, 2020
…cer overrides (apache#8124) Kafka Connect main doc required a fix to distinguish between worker level producer and consumer overrides and per-connector level producer and consumer overrides, after the latter were introduced with KIP-458. * [KAFKA-9563] Fix Kafka connect consumer and producer override documentation Co-authored-by: Konstantine Karantasis <konstantine@confluent.io> Reviewers: Konstantine Karantasis <konstantine@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The true parameters for overriding producer config or consumer config in Kafka-Connect are
producer.override.[PRODUCER-CONFIG]orconsumer.override.[CONSUMER-CONFIG]More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)