KAFKA-9533: Revert ValueTransform forwards null #8167
Merged
bbejeck merged 1 commit intoapache:trunkfrom Feb 25, 2020
Merged
Conversation
This reverts commit a41d3d8.
Member
Author
|
ping @vvcephei for review |
mjsax
reviewed
Feb 25, 2020
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
LGTM.
Should the title include the Jira name instead of being label "minor"
mjsax
reviewed
Feb 25, 2020
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
LGTM.
Should the title include the Jira name instead of being label "minor"
bbejeck
changed the title
null null
Member
Author
Agreed and updated. Thanks for the review @mjsax. |
1 similar comment
Member
Author
Agreed and updated. Thanks for the review @mjsax. |
vvcephei
approved these changes
Feb 25, 2020
Member
Author
|
merged #8167 into trunk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit a41d3d8.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)