Skip to content

KAFKA-9711 The authentication failure caused by SSLEngine#beginHandsh…#8287

Merged
junrao merged 1 commit intoapache:trunkfrom
chia7712:fix_9711
Mar 25, 2020
Merged

KAFKA-9711 The authentication failure caused by SSLEngine#beginHandsh…#8287
junrao merged 1 commit intoapache:trunkfrom
chia7712:fix_9711

Conversation

@chia7712
Copy link
Copy Markdown
Member

https://issues.apache.org/jira/browse/KAFKA-9711

 @Override
    public void handshake() throws IOException {
        if (state == State.NOT_INITALIZED)
            startHandshake(); // this line
        if (ready())
            throw renegotiationException();
        if (state == State.CLOSING)
            throw closingException();

SSLEngine#beginHandshake is possible to throw authentication failures (for example, no suitable cipher suites) so we ought to catch SSLException and then convert it to SslAuthenticationException so as to process authentication failures correctly.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@chia7712
Copy link
Copy Markdown
Member Author

@ijuma @junrao Could you take a look? thanks!

@chia7712 chia7712 force-pushed the fix_9711 branch 2 times, most recently from 610dae7 to 6fcadac Compare March 17, 2020 09:45
@chia7712
Copy link
Copy Markdown
Member Author

the flaky StateDirectoryTest.shouldReturnEmptyArrayIfListFilesReturnsNull is traced by #8310

@ijuma ijuma requested a review from rajinisivaram March 17, 2020 13:51
@chia7712 chia7712 force-pushed the fix_9711 branch 3 times, most recently from 9b01aca to fc769f1 Compare March 20, 2020 08:25
@chia7712
Copy link
Copy Markdown
Member Author

@rajinisivaram Could you take a look? thanks!

Copy link
Copy Markdown
Contributor

@junrao junrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chia7712 : Thanks for the PR. LGTM

@junrao junrao merged commit b8e508c into apache:trunk Mar 25, 2020
@chia7712 chia7712 deleted the fix_9711 branch March 25, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants