KAFKA-9730 add tag "partition" to BrokerTopicMetrics so as to observe…#8309
Closed
chia7712 wants to merge 1 commit intoapache:trunkfrom
Closed
KAFKA-9730 add tag "partition" to BrokerTopicMetrics so as to observe…#8309chia7712 wants to merge 1 commit intoapache:trunkfrom
chia7712 wants to merge 1 commit intoapache:trunkfrom
Conversation
… the partition metrics on the same broker
Member
Author
|
the flaky |
ijuma
reviewed
Mar 17, 2020
| val tags: scala.collection.Map[String, String] = name match { | ||
| case None => Map.empty | ||
| case Some(topic) => Map("topic" -> topic) | ||
| case Some(topic) => Map("topic" -> topic.topic(), "partition" -> topic.partition().toString) |
Member
There was a problem hiding this comment.
Note that this causes an explosion in the number of metrics and it will break JMX users. As such, a KIP would be required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partitionerenable us to dispatch the data to the specify partition as we wish. However, we can't observe the partition metrics if they are on the same broker. The root cause is that the key of topic metrics doesn't contain "partition" so all partitions on the same broker are merged into single metrics (see attachment).before
after
KAFKA-9730
KIP-581
Committer Checklist (excluded from commit message)