Skip to content

HOTFIX: fix flaky StateDirectoryTest.shouldReturnEmptyArrayIfListFile… #8310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guozhangwang merged 1 commit into from
Mar 18, 2020
Merged

HOTFIX: fix flaky StateDirectoryTest.shouldReturnEmptyArrayIfListFile… #8310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions streams/src/test/java/org/apache/kafka/streams/processor/internals/StateDirectoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ public void shouldReturnEmptyArrayIfStateDirDoesntExist() throws IOException {
}

@Test
public void shouldReturnEmptyArrayIfListFilesReturnsNull() {
public void shouldReturnEmptyArrayIfListFilesReturnsNull() throws IOException {
stateDir = new File(TestUtils.IO_TMP_DIR, "kafka-" + TestUtils.randomString(5));
directory = new StateDirectory(
new StreamsConfig(new Properties() {
Expand All @@ -329,9 +329,12 @@ public void shouldReturnEmptyArrayIfListFilesReturnsNull() {
time, true);
appDir = new File(stateDir, applicationId);

assertTrue(stateDir.renameTo(new File(TestUtils.IO_TMP_DIR, "state-renamed")));

assertTrue(Arrays.asList(directory.listAllTaskDirectories()).isEmpty());
// make sure the File#listFiles returns null and StateDirectory#listAllTaskDirectories is able to handle null
Utils.delete(appDir);
assertTrue(appDir.createNewFile());
assertTrue(appDir.exists());
assertNull(appDir.listFiles());
assertEquals(0, directory.listAllTaskDirectories().length);
}

@Test
Expand Down