Skip to content

MINOR: Fix javadoc warning in StreamsMetric#8314

Merged
bbejeck merged 2 commits intoapache:trunkfrom
cadonna:fix_javadoc_StreamsMetrics
Mar 19, 2020
Merged

MINOR: Fix javadoc warning in StreamsMetric#8314
bbejeck merged 2 commits intoapache:trunkfrom
cadonna:fix_javadoc_StreamsMetrics

Conversation

@cadonna
Copy link
Copy Markdown
Member

@cadonna cadonna commented Mar 19, 2020

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@cadonna
Copy link
Copy Markdown
Member Author

cadonna commented Mar 19, 2020

Call for review: @mjsax

@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Mar 19, 2020

ok to test

@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Mar 19, 2020

@cadonna the failure is from checkstyle, unused import

@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Mar 19, 2020

retest this please

@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Mar 19, 2020

ok to test

Copy link
Copy Markdown
Member

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @cadonna LGTM.

@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Mar 19, 2020

Java 8 passed, Java 11 failed.

This PR contains only Javadoc changes so merging now.

@bbejeck bbejeck merged commit 0174c95 into apache:trunk Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants