KAFKA-8639: Replace AddPartitionsToTxn with Automated Protocol #8326
Merged
guozhangwang merged 3 commits intoapache:trunkfrom Apr 24, 2020
Merged
KAFKA-8639: Replace AddPartitionsToTxn with Automated Protocol #8326guozhangwang merged 3 commits intoapache:trunkfrom
guozhangwang merged 3 commits intoapache:trunkfrom
Conversation
abbccdda
commented
Mar 21, 2020
abbccdda
commented
Mar 22, 2020
Author
There was a problem hiding this comment.
Only side cleanups in this file
abbccdda
changed the title
abbccdda
commented
Apr 11, 2020
abbccdda
commented
Apr 11, 2020
abbccdda
commented
Apr 11, 2020
Author
There was a problem hiding this comment.
The test only checks partition 0, no need for 3 partitions
Contributor
|
test this |
|
|
||
| public List<TopicPartition> partitions() { | ||
| return partitions; | ||
| return Builder.getPartitions(data); |
Contributor
There was a problem hiding this comment.
Although today we are only calling this func once, if in the future we call it multiple times we'd pay the cycles each time to parse the map into the list. Could we cache the parsed list locally and when it is called again we can avoid Builder.getPartitions?
| public AddPartitionsToTxnResponse getErrorResponse(int throttleTimeMs, Throwable e) { | ||
| final HashMap<TopicPartition, Errors> errors = new HashMap<>(); | ||
| for (TopicPartition partition : partitions) { | ||
| for (TopicPartition partition : Builder.getPartitions(data)) { |
Contributor
There was a problem hiding this comment.
Same here, we can cache the result of Builder.getPartitions(data) for re-use.
|
|
||
| public Map<TopicPartition, Errors> errors() { | ||
| return errors; | ||
| Map<TopicPartition, Errors> errorsMap = new HashMap<>(); |
Contributor
There was a problem hiding this comment.
Similar here, we can cache the result in case to be reused.
| class AddPartitionsToTxnRequestTest extends BaseRequestTest { | ||
| private val topic1 = "foobartopic" | ||
| val numPartitions = 3 | ||
| class AddPartitionsToTxnRequestServerTest extends BaseRequestTest { |
Contributor
There was a problem hiding this comment.
Why we want to change the test name?
Author
There was a problem hiding this comment.
Because its name has a conflict with our added AddPartitionsToTxnRequestTest, just want to clarify that.
added 2 commits
April 22, 2020 20:01
Contributor
|
test this please |
Author
|
Test only fails the flaky test: kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup |
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Apr 29, 2020
…t-for-generated-requests * apache-github/trunk: (366 commits) MINOR: Improve producer test BufferPoolTest#testCloseNotifyWaiters. (apache#7982) MINOR: document how to escape json parameters to ducktape tests (apache#8546) KAFKA-9885; Evict last members of a group when the maximum allowed is reached (apache#8525) KAFKA-9866: Avoid election for topics where preferred leader is not in ISR (apache#8524) KAFKA-9839; Broker should accept control requests with newer broker epoch (apache#8509) KAKFA-9612: Add an option to kafka-configs.sh to add configs from a prop file (KIP-574) MINOR: Partition is under reassignment when adding and removing (apache#8364) MINOR: reduce allocations in log start and recovery checkpoints (apache#8467) MINOR: Remove unused foreign-key join class (apache#8547) HOTFIX: Fix broker bounce system tests (apache#8532) KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap. (apache#8224) KAFKA-8639: Replace AddPartitionsToTxn with Automated Protocol (apache#8326) MINOR: equals() should compare all fields for generated classes (apache#8539) KAFKA-9844; Fix race condition which allows more than maximum number of members(apache#8454) KAFKA-9823: Remember the sent generation for the coordinator request (apache#8445) KAFKA-9883: Add better error message when REST API forwards a request and leader is not known (apache#8536) KAFKA-9907: Switch default build to Scala 2.13 (apache#8537) MINOR: Some html fixes in Streams DSL documentation (apache#8503) MINOR: Enable fatal warnings with scala 2.13 (apache#8429) KAFKA-9852: Change the max duration that calls to the buffer pool can block from 2000ms to 10ms to reduce overall test runtime (apache#8464) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the protocol automation effort.
Committer Checklist (excluded from commit message)