KAFKA-9763: Correct InsertField to not skip keys of tombstone records#8351
Closed
rhauch wants to merge 1 commit intoapache:trunkfrom
Closed
KAFKA-9763: Correct InsertField to not skip keys of tombstone records#8351rhauch wants to merge 1 commit intoapache:trunkfrom
rhauch wants to merge 1 commit intoapache:trunkfrom
Conversation
The fix for KAFKA-8523 attempted to skip (immediately returns) tombstone records when InsertField$Value is used. However, it also inadvertently also skips tombstone records when InsertField$Key is used, despite the possibility that the tombstone record’s key is non null. This commit corrects the behavior so that the InsertField$Value continues to skip tombstone records, but InsertField$Key only skips when the record’s *key* is null. Added two unit tests, and verified that these tests fail on the previous code and pass with the proposed fix.
Contributor
Author
|
Closed in favor of #8280 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix for KAFKA-8523 attempted to skip (immediately returns) tombstone records when InsertField$Value is used. However, it also inadvertently also skips tombstone records when InsertField$Key is used, despite the possibility that the tombstone record’s key is non null.
This commit corrects the behavior so that the InsertField$Value continues to skip tombstone records, but InsertField$Key only skips when the record’s key is null.
Added two unit tests, and verified that these tests fail without the proposed fix and pass with the proposed fix. The other unit tests were added with KAFKA-8523 continue to pass.
This should be backported all the way back to the 1.0 branch, since that's how far back KAFKA-8523 was backported.
Committer Checklist (excluded from commit message)