KAFKA-9771: Port patch for inter-worker Connect SSL from Jetty 9.4.25#8369
Merged
kkonstantine merged 2 commits intoapache:trunkfrom Mar 27, 2020
Merged
KAFKA-9771: Port patch for inter-worker Connect SSL from Jetty 9.4.25#8369kkonstantine merged 2 commits intoapache:trunkfrom
kkonstantine merged 2 commits intoapache:trunkfrom
Conversation
Contributor
|
ok to test |
jeffhuang26
approved these changes
Mar 27, 2020
kkonstantine
approved these changes
Mar 27, 2020
Contributor
kkonstantine
left a comment
kkonstantine
left a comment
There was a problem hiding this comment.
LGTM
Thanks for the fix @C0urante and the review @jeffhuang26 !
kkonstantine
pushed a commit
that referenced
this pull request
Mar 27, 2020
…#8369) For reasons outlined in https://issues.apache.org/jira/browse/KAFKA-9771 we can't upgrade to a version of Jetty with the bug fixed, or downgrade to one prior to the introduction of the bug. Luckily, the actual fix is pretty straightforward and can be ported over to Connect for use until it's possible to upgrade to a version of Jetty with that bug fixed: https://github.com/eclipse/jetty.project/pull/4404/files#diff-58640db0f8f2cd84b7e653d1c1540913R2188-R2193 The changes here have been verified locally; a test with multiple certificates/multiple hostnames will be submitted in a follow up. Reviewers: Jeff Huang <47870461+jeffhuang26@users.noreply.github.com>, Konstantine Karantasis <konstantine@confluent.io>
Contributor
|
Merged to |
3 tasks
akatona84
added a commit
to akatona84/kafka
that referenced
this pull request
Jun 15, 2020
…y 9.4.25 (apache#8369)" This reverts commit ee832d7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
For reasons outlined in the ticket, we can't upgrade to a version of Jetty with the bug fixed, or downgrade to one prior to the introduction of the bug. Luckily, the actual fix is pretty straightforward and can be ported over to Connect for use until it's possible to upgrade to a version of Jetty with that bug fixed: https://github.com/eclipse/jetty.project/pull/4404/files#diff-58640db0f8f2cd84b7e653d1c1540913R2188-R2193
The changes here have been verified locally; currently investigating how they can best be tested via unit/integration/system tests.
Committer Checklist (excluded from commit message)