Skip to content

MINOR: Rename TopicCommandTest#8398

Merged
ijuma merged 1 commit intoapache:trunkfrom
jsancio:minor-rename-topic-command-test
Apr 1, 2020
Merged

MINOR: Rename TopicCommandTest#8398
ijuma merged 1 commit intoapache:trunkfrom
jsancio:minor-rename-topic-command-test

Conversation

@jsancio
Copy link
Copy Markdown
Member

@jsancio jsancio commented Mar 31, 2020

Rename the test suite to later add unittests that don't depend on
ZK or the AdminClient TopiCommand types.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Rename the test suite to later add unittests that don't depend on
ZK or the AdminClient TopiCommand types.
@jsancio
Copy link
Copy Markdown
Member Author

jsancio commented Mar 31, 2020

Here is the rename @ijuma. I'll resolve the conflicts in #8364, if any, once this is merged.

Copy link
Copy Markdown
Member

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Apr 1, 2020

ok to test

@jsancio
Copy link
Copy Markdown
Member Author

jsancio commented Apr 1, 2020

One failure unrelated to this change

org.scalatest.exceptions.TestFailedException: The remaining consumers in the group could not fetch the expected records
	at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:530)
	at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:529)
	at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1389)
	at org.scalatest.Assertions.fail(Assertions.scala:1091)
	at org.scalatest.Assertions.fail$(Assertions.scala:1087)
	at org.scalatest.Assertions$.fail(Assertions.scala:1389)
	at kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup(ConsumerBounceTest.scala:329)

@ijuma ijuma merged commit fee5f0e into apache:trunk Apr 1, 2020
@jsancio jsancio deleted the minor-rename-topic-command-test branch April 1, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants