Skip to content

KAFKA-9739: Fixes null key changing child node#8416

Merged
bbejeck merged 2 commits intoapache:2.4from
bbejeck:KAFKA-9739_24_branch_null_keyChangingChildNode
Apr 3, 2020
Merged

KAFKA-9739: Fixes null key changing child node#8416
bbejeck merged 2 commits intoapache:2.4from
bbejeck:KAFKA-9739_24_branch_null_keyChangingChildNode

Conversation

@bbejeck
Copy link
Copy Markdown
Member

@bbejeck bbejeck commented Apr 3, 2020

2.4 port of #8400 since cherry-picking not possible

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@bbejeck
Copy link
Copy Markdown
Member Author

bbejeck commented Apr 3, 2020

@vvcephei can you take a look this? It's identical to #8400, just for 2.4 branch. Once merged I'll cherry-pick this back.

Copy link
Copy Markdown
Contributor

@vvcephei vvcephei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Pending the tests ;) )

Thanks again, @bbejeck

@bbejeck bbejeck merged commit 9c91e05 into apache:2.4 Apr 3, 2020
@bbejeck
Copy link
Copy Markdown
Member Author

bbejeck commented Apr 3, 2020

merged #8416 into 2.4

@bbejeck bbejeck deleted the KAFKA-9739_24_branch_null_keyChangingChildNode branch April 3, 2020 19:14
bbejeck added a commit to bbejeck/kafka that referenced this pull request Apr 3, 2020
2.4 port of apache#8400 since cherry-picking not possible

Reviewers: John Roesler <john@confluent.io>
qq619618919 pushed a commit to qq619618919/kafka that referenced this pull request May 12, 2020
2.4 port of apache#8400 since cherry-picking not possible

Reviewers: John Roesler <john@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants