Skip to content

KAFKA-8611 / Refactor KStreamRepartitionIntegrationTest#8470

Merged
mjsax merged 3 commits intoapache:trunkfrom
lkokhreidze:KAFKA-8611-follow-up-refactoring
Apr 15, 2020
Merged

KAFKA-8611 / Refactor KStreamRepartitionIntegrationTest#8470
mjsax merged 3 commits intoapache:trunkfrom
lkokhreidze:KAFKA-8611-follow-up-refactoring

Conversation

@lkokhreidze
Copy link
Copy Markdown
Contributor

Follow-up PR on #7170 that implements @mjsax 's suggestions regarding integration test parameters.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Apr 13, 2020

Retest this please.

@mjsax mjsax added streams tests Test fixes (including flaky tests) labels Apr 13, 2020
Copy link
Copy Markdown
Member

@mjsax mjsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Assuming Jenkins passes.

Thanks for the follow up @lkokhreidze!

@lkokhreidze
Copy link
Copy Markdown
Contributor Author

Hi @mjsax :streams:compileTestJava was failing. Should be fixed now.

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Apr 13, 2020

Retest this please.

1 similar comment
@mjsax
Copy link
Copy Markdown
Member

mjsax commented Apr 14, 2020

Retest this please.

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Apr 14, 2020

Java 11: org.apache.kafka.streams.integration.EosIntegrationTest.shouldNotViolateEosIfOneTaskFailsWithState[exactly_once_beta]
Java 8: https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/1747/testReport/junit/org.apache.kafka.streams.integration/EosIntegrationTest/shouldNotViolateEosIfOneTaskFailsWithState_exactly_once_/

Retest this please.

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Apr 15, 2020

Java 8 passed.
Java 11:

kafka.server.epoch.EpochDrivenReplicationProtocolAcceptanceTest.shouldSurviveFastLeaderChangeorg.apache.kafka.streams.integration.SuppressionDurabilityIntegrationTest.shouldRecoverBufferAfterShutdown[exactly_once]

@mjsax mjsax merged commit 742f928 into apache:trunk Apr 15, 2020
@mjsax
Copy link
Copy Markdown
Member

mjsax commented Apr 15, 2020

Thanks for the follow up @lkokhreidze!

I just realized that we did not update the docs for KIP-221. Could you help with that?

@lkokhreidze
Copy link
Copy Markdown
Contributor Author

Hi @mjsax, will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

streams tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants