KAFKA-9901:Fix streams_broker_bounce_test error#8529
Closed
jiameixie wants to merge 1 commit intoapache:trunkfrom
Closed
KAFKA-9901:Fix streams_broker_bounce_test error#8529jiameixie wants to merge 1 commit intoapache:trunkfrom
jiameixie wants to merge 1 commit intoapache:trunkfrom
Conversation
The constructor of StreamsSmokeTestJobRunnerService has been changed. But it's not updated in streams_broker_bounce_test.py, which makes num_threads = 3 to be processing_guarantee's value and causes that StreamsTest can't startup Change-Id: I07ebc3e007e0ddd0b5182d5cf9467cdfac993eae Signed-off-by: Jiamei Xie <jiamei.xie@arm.com>
Contributor
Author
|
@guozhangwang @ijuma @junrao PTAL, thanks |
Member
|
In order to avoid duplicate work, I just want to let you know that I also have a PR that fixes this issue the same way #8532. I have already run the system tests on that PR to verify the fix. On my PR, there is also a discussion on which value to set the new constructor parameter. You can merge this or the other PR, I do not care. I just wanted to let you know. |
Member
|
@jiameixie My PR was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constructor of StreamsSmokeTestJobRunnerService has been changed.
But it's not updated in streams_broker_bounce_test.py, which makes
num_threads = 3 to be processing_guarantee's value and causes that
StreamsTest can't startup
Change-Id: I07ebc3e007e0ddd0b5182d5cf9467cdfac993eae
Signed-off-by: Jiamei Xie jiamei.xie@arm.com
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)