Skip to content

KAFKA-9901:Fix streams_broker_bounce_test error#8529

Closed
jiameixie wants to merge 1 commit intoapache:trunkfrom
jiameixie:streams_broker_bounce_test
Closed

KAFKA-9901:Fix streams_broker_bounce_test error#8529
jiameixie wants to merge 1 commit intoapache:trunkfrom
jiameixie:streams_broker_bounce_test

Conversation

@jiameixie
Copy link
Copy Markdown
Contributor

The constructor of StreamsSmokeTestJobRunnerService has been changed.
But it's not updated in streams_broker_bounce_test.py, which makes
num_threads = 3 to be processing_guarantee's value and causes that
StreamsTest can't startup

Change-Id: I07ebc3e007e0ddd0b5182d5cf9467cdfac993eae
Signed-off-by: Jiamei Xie jiamei.xie@arm.com

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

The constructor of StreamsSmokeTestJobRunnerService has been changed.
But it's not updated in streams_broker_bounce_test.py, which makes
num_threads = 3 to be processing_guarantee's value and causes that
StreamsTest can't startup

Change-Id: I07ebc3e007e0ddd0b5182d5cf9467cdfac993eae
Signed-off-by: Jiamei Xie <jiamei.xie@arm.com>
@jiameixie
Copy link
Copy Markdown
Contributor Author

@guozhangwang @ijuma @junrao PTAL, thanks

@cadonna
Copy link
Copy Markdown
Member

cadonna commented Apr 24, 2020

In order to avoid duplicate work, I just want to let you know that I also have a PR that fixes this issue the same way #8532. I have already run the system tests on that PR to verify the fix. On my PR, there is also a discussion on which value to set the new constructor parameter. You can merge this or the other PR, I do not care. I just wanted to let you know.

@cadonna
Copy link
Copy Markdown
Member

cadonna commented Apr 24, 2020

@jiameixie My PR was merged.

@jiameixie jiameixie closed this Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants