KAFKA-9176: Retry on getting local stores from KafkaStreams #8568
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,7 +43,6 @@ | |
| import org.apache.kafka.streams.StreamsBuilder; | ||
| import org.apache.kafka.streams.StreamsConfig; | ||
| import org.apache.kafka.streams.KeyQueryMetadata; | ||
| import org.apache.kafka.streams.integration.utils.EmbeddedKafkaCluster; | ||
| import org.apache.kafka.streams.integration.utils.IntegrationTestUtils; | ||
| import org.apache.kafka.streams.kstream.Consumed; | ||
|
|
@@ -119,11 +118,8 @@ public void shouldApplyUpdatesToStandbyStore() throws Exception { | |
| // Assert that all messages in the first batch were processed in a timely manner | ||
| assertThat(semaphore.tryAcquire(batch1NumMessages, 60, TimeUnit.SECONDS), is(equalTo(true))); | ||
|
|
||
| final ReadOnlyKeyValueStore<Integer, Integer> store1 = IntegrationTestUtils.getStore(TABLE_NAME, kafkaStreams1, QueryableStoreTypes.keyValueStore()); | ||
| final ReadOnlyKeyValueStore<Integer, Integer> store2 = IntegrationTestUtils.getStore(TABLE_NAME, kafkaStreams2, QueryableStoreTypes.keyValueStore()); | ||
|
|
||
| final boolean kafkaStreams1WasFirstActive; | ||
| final KeyQueryMetadata keyQueryMetadata = kafkaStreams1.queryMetadataForKey(TABLE_NAME, key, (topic, somekey, value, numPartitions) -> 0); | ||
|
|
@@ -163,8 +159,10 @@ public void shouldApplyUpdatesToStandbyStore() throws Exception { | |
| // Assert that all messages in the second batch were processed in a timely manner | ||
| assertThat(semaphore.tryAcquire(batch2NumMessages, 60, TimeUnit.SECONDS), is(equalTo(true))); | ||
|
Member
There was a problem hiding this comment.
|
||
|
|
||
| TestUtils.retryOnExceptionWithTimeout(100, 60 * 1000, () -> { | ||
|
Contributor
Author
There was a problem hiding this comment. This is a minor fix, that we should retry this condition. |
||
| // Assert that the current value in store reflects all messages being processed | ||
| assertThat(newActiveStore.get(key), is(equalTo(totalNumMessages - 1))); | ||
| }); | ||
| } | ||
|
|
||
| private void produceValueRange(final int key, final int start, final int endExclusive) throws Exception { | ||
|
|
@@ -227,10 +225,11 @@ private Properties streamsConfiguration() { | |
| config.put(StreamsConfig.DEFAULT_KEY_SERDE_CLASS_CONFIG, Serdes.Integer().getClass()); | ||
| config.put(StreamsConfig.DEFAULT_VALUE_SERDE_CLASS_CONFIG, Serdes.Integer().getClass()); | ||
| config.put(StreamsConfig.NUM_STANDBY_REPLICAS_CONFIG, 1); | ||
| config.put(StreamsConfig.COMMIT_INTERVAL_MS_CONFIG, 100); | ||
| config.put(StreamsConfig.CACHE_MAX_BYTES_BUFFERING_CONFIG, 0); | ||
|
Contributor
Author
There was a problem hiding this comment. This is a fix to the test itself: with caching the records are delayed sending to the sink topics. |
||
| config.put(ConsumerConfig.MAX_POLL_RECORDS_CONFIG, 100); | ||
| config.put(ConsumerConfig.HEARTBEAT_INTERVAL_MS_CONFIG, 200); | ||
| config.put(ConsumerConfig.SESSION_TIMEOUT_MS_CONFIG, 1000); | ||
| return config; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have to check for null now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since previously we would just throw the exception with the un-wrapped call, here asserting it is not null is equal to make sure that the store is indeed returned.