Skip to content

KAFKA-9127: don't create StreamThreads for global-only topology (2.4)#8616

Merged
vvcephei merged 4 commits intoapache:2.4from
ableegoldman:9127-global-only-topology-for-2-4
May 8, 2020
Merged

KAFKA-9127: don't create StreamThreads for global-only topology (2.4)#8616
vvcephei merged 4 commits intoapache:2.4from
ableegoldman:9127-global-only-topology-for-2-4

Conversation

@ableegoldman
Copy link
Copy Markdown
Member

Copy of pull/8540 targeted at 2.4

…he#8540)

Reviewers: Matthias J. Sax <matthias@confluent.io>, John Roesler <vvcephei@apache.org>
@ableegoldman
Copy link
Copy Markdown
Member Author

@vvcephei

@vvcephei
Copy link
Copy Markdown
Contributor

vvcephei commented May 5, 2020

test this please

@vvcephei
Copy link
Copy Markdown
Contributor

vvcephei commented May 5, 2020

retest this please

@vvcephei
Copy link
Copy Markdown
Contributor

vvcephei commented May 5, 2020

test this please

2 similar comments
@vvcephei
Copy link
Copy Markdown
Contributor

vvcephei commented May 5, 2020

test this please

@vvcephei
Copy link
Copy Markdown
Contributor

vvcephei commented May 5, 2020

test this please

@ableegoldman
Copy link
Copy Markdown
Member Author

@vvcephei Both Java 11 builds passed, Java 8 failed with flaky
DynamicBrokerReconfigurationTest.testAddRemoveSaslListeners
BranchedMultiLevelRepartitionConnectedTopologyTest.testTopologyBuild

(the Streams one is not related, it was converted to a unit test to reduce flakiness but that PR was not backported to 2.4)

@vvcephei
Copy link
Copy Markdown
Contributor

vvcephei commented May 8, 2020

Thanks @ableegoldman ! Merging...

@vvcephei vvcephei merged commit 8d54432 into apache:2.4 May 8, 2020
@ableegoldman ableegoldman deleted the 9127-global-only-topology-for-2-4 branch May 8, 2020 19:31
qq619618919 pushed a commit to qq619618919/kafka that referenced this pull request May 12, 2020
…apache#8616)

Backports: apache#8540

Reviewers: Matthias J. Sax <matthias@confluent.io>, John Roesler <vvcephei@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants