KAFKA-9921: explicit handling of null values with retainDuplicates#8626
Merged
mjsax merged 5 commits intoapache:trunkfrom May 11, 2020
Merged
KAFKA-9921: explicit handling of null values with retainDuplicates#8626mjsax merged 5 commits intoapache:trunkfrom
mjsax merged 5 commits intoapache:trunkfrom
Conversation
Member
|
Retest this please |
GeorgiPetkov
reviewed
May 8, 2020
Co-authored-by: GeorgiPetkov <gp000077@gmail.com>
Member
|
Retest this please |
mjsax
approved these changes
May 8, 2020
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
LGTM (assuming Jenkins passes).
Member
|
Retest this please. |
Member
Author
|
Java 14 passed, Java 8 and Java 11 has one failure each but results cleaned up already. |
mjsax
pushed a commit
that referenced
this pull request
May 11, 2020
…8626) Reviewer: Matthias J. Sax <matthias@confluent.io>
Member
|
Merged to |
jwijgerd
pushed a commit
to buxapp/kafka
that referenced
this pull request
May 14, 2020
…pache#8626) Reviewer: Matthias J. Sax <matthias@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general the behavior of window stores with
retainDuplicatesis not well documented or enforced, so we should attempt to clarify things better in the javadocs and in the code itself. This explicitly skips the put/delete when the value is null and duplicates are allowed, and specifies this behavior in the docs.Also adds in a test I left out in the earlier PR #8564