KAFKA-9332 change how to get joinGroupTimeoutMs#8741
Closed
sasukerui wants to merge 1 commit intoapache:2.0from
Closed
KAFKA-9332 change how to get joinGroupTimeoutMs#8741sasukerui wants to merge 1 commit intoapache:2.0from
sasukerui wants to merge 1 commit intoapache:2.0from
Conversation
ijuma
reviewed
May 30, 2020
| // maximum time that it may block on the coordinator. We add an extra 5 seconds for small delays. | ||
|
|
||
| int joinGroupTimeoutMs = Math.max(rebalanceTimeoutMs, rebalanceTimeoutMs + 5000); | ||
| int joinGroupTimeoutMs = rebalanceTimeoutMs + 5000; |
Member
There was a problem hiding this comment.
The previous code handles overflow.
Contributor
There was a problem hiding this comment.
I think the original code was unintentional. We changed it in #8702 to the following:
int joinGroupTimeoutMs = Math.max(client.defaultRequestTimeoutMs(),
rebalanceConfig.rebalanceTimeoutMs + JOIN_GROUP_TIMEOUT_LAPSE);
Contributor
|
Thanks for the patch. I'm going to close this since the code was changed separately. I don't think there's a strong reason to port the change back to 2.0, but let us know if there is a specific reason why it's necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rebalanceTimeoutMs + 5000 is always greater than rebalanceTimeoutMs