Skip to content

KAFKA-10081: Remove an unused local variable to pass spotbugsMain check#8774

Merged
mjsax merged 1 commit intoapache:trunkfrom
showuon:KAFKA-10081
Jun 2, 2020
Merged

KAFKA-10081: Remove an unused local variable to pass spotbugsMain check#8774
mjsax merged 1 commit intoapache:trunkfrom
showuon:KAFKA-10081

Conversation

@showuon
Copy link
Copy Markdown
Member

@showuon showuon commented Jun 2, 2020

This issue can also reproduce in local environment. I Investigated why the spotbugs failed, and found that there's a warning to an unused local variable.

Dead store to isFreshAssignment in org.apache.kafka.clients.consumer.internals.AbstractStickyAssignor.generalAssign(Map, Map)

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@showuon
Copy link
Copy Markdown
Member Author

showuon commented Jun 2, 2020

@mjsax @ableegoldman @abbccdda , could you review this PR since it keeps breaking the recent builds.

Copy link
Copy Markdown
Member

@ableegoldman ableegoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Jun 2, 2020

Retest this please.

@chia7712
Copy link
Copy Markdown
Member

chia7712 commented Jun 2, 2020

testReassignmentWithRandomSubscriptionsAndChanges is traced by #8778
testMultiConsumerStickyAssignment is traced by #8777

+1 to merge this hotfix :)

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Jun 2, 2020

Java 11: env issue
Java 14:

org.apache.kafka.clients.consumer.CooperativeStickyAssignorTest.testReassignmentWithRandomSubscriptionsAndChanges
org.apache.kafka.clients.consumer.StickyAssignorTest.testReassignmentWithRandomSubscriptionsAndChanges
kafka.api.PlaintextConsumerTest.testMultiConsumerStickyAssignment

Java 8:

org.apache.kafka.clients.consumer.CooperativeStickyAssignorTest.testReassignmentWithRandomSubscriptionsAndChanges
org.apache.kafka.clients.consumer.CooperativeStickyAssignorTest.testReassignmentWithRandomSubscriptionsAndChanges
org.apache.kafka.clients.consumer.StickyAssignorTest.testReassignmentWithRandomSubscriptionsAndChanges
org.apache.kafka.clients.consumer.StickyAssignorTest.testReassignmentWithRandomSubscriptionsAndChanges
kafka.api.PlaintextConsumerTest.testMultiConsumerStickyAssignment
kafka.api.PlaintextConsumerTest.testMultiConsumerStickyAssignment

@mjsax mjsax merged commit 1d7168c into apache:trunk Jun 2, 2020
@ijuma
Copy link
Copy Markdown
Member

ijuma commented Jun 2, 2020

Btw, this had already been fixed by a3d79ff .

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Jun 2, 2020

Thanks for pointing out. This PR was opened first though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants