KAFKA-10081: Remove an unused local variable to pass spotbugsMain check#8774
Merged
mjsax merged 1 commit intoapache:trunkfrom Jun 2, 2020
Merged
KAFKA-10081: Remove an unused local variable to pass spotbugsMain check#8774mjsax merged 1 commit intoapache:trunkfrom
mjsax merged 1 commit intoapache:trunkfrom
Conversation
Member
Author
|
@mjsax @ableegoldman @abbccdda , could you review this PR since it keeps breaking the recent builds. |
ableegoldman
approved these changes
Jun 2, 2020
Member
ableegoldman
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
Member
|
Retest this please. |
chia7712
approved these changes
Jun 2, 2020
Member
Member
|
Java 11: env issue Java 8: |
Member
|
Btw, this had already been fixed by a3d79ff . |
Member
|
Thanks for pointing out. This PR was opened first though :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue can also reproduce in local environment. I Investigated why the spotbugs failed, and found that there's a warning to an unused local variable.
Committer Checklist (excluded from commit message)