KAFKA-9432:(follow-up) Set configKeys to null in describeConfigs() to make it backward compatible with older Kafka versions.#9046
Closed
omkreddy wants to merge 1 commit intoapache:trunkfrom
Closed
Conversation
… make it backward compatible with older Kafka versions.
rajinisivaram
approved these changes
Jul 21, 2020
Contributor
rajinisivaram
left a comment
rajinisivaram
left a comment
There was a problem hiding this comment.
@omkreddy Thanks for the PR, LGTM
Contributor
Author
|
@rajinisivaram Thanks for the review. Merging to trunk. |
vcrfxia
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jul 22, 2020
…` to make it backward compatible with older Kafka versions. - After apache#8312, older brokers are returning empty configs, with latest `adminClient.describeConfigs`. Old brokers are receiving empty configNames in `AdminManageer.describeConfigs()` method. Older brokers does not handle empty configKeys. Due to this old brokers are filtering all the configs. - Update ClientCompatibilityTest to verify describe configs - Add test case to test describe configs with empty configuration Keys Author: Manikumar Reddy <manikumar.reddy@gmail.com> Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com> Closes apache#9046 from omkreddy/KAFKA-9432
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adminClient.describeConfigs. Old brokers are receiving empty configNames inAdminManageer.describeConfigs()method. Older brokers does not handle empty configKeys. Due to this old brokers are filtering all the configs.Committer Checklist (excluded from commit message)