Skip to content

MINOR: Fix failing test due to KAFKA-10556 PR #9372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rajinisivaram merged 2 commits into from
Oct 6, 2020
Merged

MINOR: Fix failing test due to KAFKA-10556 PR #9372

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
986b03f
MINOR: Fix failing test due to KAFKA-10556 PR
rondagostino Oct 4, 2020
e822e7b
Remove ineffective comment as per review
rondagostino Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions core/src/test/scala/integration/kafka/api/MetricsTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import org.apache.kafka.common.config.SaslConfigs
import org.apache.kafka.common.errors.InvalidTopicException
import org.apache.kafka.common.network.ListenerName
import org.apache.kafka.common.security.auth.SecurityProtocol
import org.apache.kafka.common.security.authenticator.TestJaasConfig
import org.junit.{After, Before, Test}
import org.junit.Assert._
import org.scalatest.Assertions.fail
Expand Down Expand Up @@ -113,8 +114,8 @@ class MetricsTest extends IntegrationTestHarness with SaslSetup {
// Create a producer that fails authentication to verify authentication failure metrics
private def generateAuthenticationFailure(tp: TopicPartition): Unit = {
val saslProps = new Properties()
// Temporary limit to reduce blocking before KIP-152 client-side changes are merged
saslProps.put(SaslConfigs.SASL_MECHANISM, "SCRAM-SHA-256")
saslProps.put(SaslConfigs.SASL_MECHANISM, kafkaClientSaslMechanism)
saslProps.put(SaslConfigs.SASL_JAAS_CONFIG, TestJaasConfig.jaasConfigProperty(kafkaClientSaslMechanism, "badUser", "badPass"))
// Use acks=0 to verify error metric when connection is closed without a response
val producer = TestUtils.createProducer(brokerList,
acks = 0,
Expand Down