KAFKA-10645: Add null check to the array/Iterable values in RecordHeaders constructor#9518
Closed
showuon wants to merge 1 commit intoapache:trunkfrom
Closed
KAFKA-10645: Add null check to the array/Iterable values in RecordHeaders constructor#9518showuon wants to merge 1 commit intoapache:trunkfrom
showuon wants to merge 1 commit intoapache:trunkfrom
Conversation
Member
Author
|
@mjsax , could you review this PR? Thanks. |
Member
Member
Author
|
Yes, it's it... >.< Thanks for reminding! |
Member
|
@showuon Seems we worked on this in parallel. Sorry for that... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #6484, we add null check while adding headers with
add()method, but we forgot to protect it while user passing the headers with null value in constructor. Add it and add tests.Committer Checklist (excluded from commit message)