KAFKA-10658 ErrantRecordReporter.report always return completed futur…#9525
Merged
chia7712 merged 3 commits intoapache:trunkfrom Jan 28, 2021
Merged
KAFKA-10658 ErrantRecordReporter.report always return completed futur…#9525chia7712 merged 3 commits intoapache:trunkfrom
chia7712 merged 3 commits intoapache:trunkfrom
Conversation
Member
Author
|
@aakashnshah @rhauch @kkonstantine Could you take a look? This issue was related to #8720 and you guys are experts on that. |
showuon
reviewed
Oct 29, 2020
Member
showuon
left a comment
showuon
left a comment
There was a problem hiding this comment.
Nice find! Left a small suggestion!
chia7712
force-pushed
the
KAFKA-10658
branch
2 times, most recently
from
70a27f2 to
d729abf
Compare
…e even though the record is not sent to DLQ topic yet
chia7712
force-pushed
the
KAFKA-10658
branch
from
d729abf to
5710d4e
Compare
Member
Author
|
@dajac Could you please take a look? |
kkonstantine
approved these changes
Jan 28, 2021
chia7712
added a commit
that referenced
this pull request
Jan 28, 2021
#9525) Reviewers: Konstantine Karantasis <k.karantasis@gmail.com>
Member
Author
|
merge to trunk, 2.7 and 2.6 |
chia7712
added a commit
that referenced
this pull request
Jan 28, 2021
#9525) Reviewers: Konstantine Karantasis <k.karantasis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: https://issues.apache.org/jira/browse/KAFKA-10658
This issue happens when both DLQ and error log are enabled. There is a incorrect filter in handling multiple reports and it results in the uncompleted future is filtered out. Hence, users always receive a completed future even though the record is still in producer buffer.
Committer Checklist (excluded from commit message)