MINOR: Configure reconnect backoff in BrokerToControllerChannelManager#9709
Merged
hachikuji merged 1 commit intoapache:trunkfrom Dec 8, 2020
Conversation
abbccdda
approved these changes
Dec 7, 2020
chia7712
approved these changes
Dec 8, 2020
Member
|
|
mumrah
approved these changes
Dec 8, 2020
Member
mumrah
left a comment
mumrah
left a comment
There was a problem hiding this comment.
I believe the constructor calls here were copied from ControllerChannelManager. Do we want to add a reconnect backoff max there as well?
As a side note, we probably want a better way of setting up these classes that always go together (ChannelBuilder, Selector, NetworkClient).
Contributor
Author
|
@mumrah Yeah, I noticed that too. I think |
hachikuji
added a commit
that referenced
this pull request
Dec 15, 2020
…er` (#9709) We should configure a reconnect backoff for controller connections to prevent tight reconnect loops when the controller cannot be reached. I have borrowed the same configuration we use in `TransactionMarkerChannelManager`. Reviewers: David Arthur <mumrah@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>, Boyang Chen <boyang@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should configure a reconnect backoff for controller connections to prevent tight reconnect loops when the controller cannot be reached. I have borrowed the same configuration we use in
TransactionMarkerChannelManager.Committer Checklist (excluded from commit message)