Skip to content

MINOR: Skip Struct conversion in FetchRequest.parse#9740

Merged
ijuma merged 1 commit intoapache:trunkfrom
dengziming:KAFKA-10818-fetch-fix
Dec 13, 2020
Merged

MINOR: Skip Struct conversion in FetchRequest.parse#9740
ijuma merged 1 commit intoapache:trunkfrom
dengziming:KAFKA-10818-fetch-fix

Conversation

@dengziming
Copy link
Copy Markdown
Member

More detailed description of your change

when I was review #7409 , I accidentally found that FetchRequest is missed.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@dengziming
Copy link
Copy Markdown
Member Author

Hi, @ijuma PTAL.

Copy link
Copy Markdown
Member

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@ijuma ijuma changed the title MINOR; KAFKA-10818 skip convert to struct for FetchRequest MINOR: Skip Struct conversion in FetchRequest.parse Dec 13, 2020
@ijuma ijuma merged commit 3572049 into apache:trunk Dec 13, 2020
@dengziming dengziming deleted the KAFKA-10818-fetch-fix branch October 8, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants